KEMBAR78
docs: Copy all storage samples from java-docs-samples by JesseLovelace · Pull Request #1258 · googleapis/java-storage · GitHub
Skip to content

Conversation

@JesseLovelace
Copy link
Contributor

@JesseLovelace JesseLovelace commented Feb 16, 2022

Internal bug b/190102205.

Makes a copy of all (published) samples from java-docs-samples. Leaves behind everything that isn't published.

After this is merged, all docs pages will be updated to refer to these instead of the samples in java-docs-samples. Then, the java-docs-samples samples will be deleted.

This will allow anyone developing new library features to include samples in the same PR

@generated-files-bot
Copy link

generated-files-bot bot commented Feb 16, 2022

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/samples.cfg
  • .kokoro/presubmit/samples.cfg
  • samples/install-without-bom/pom.xml
  • samples/snapshot/pom.xml

@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Feb 16, 2022
@JesseLovelace JesseLovelace changed the title Copy all storage samples from java-docs-samples (feat) Copy all storage samples from java-docs-samples Feb 16, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 16, 2022

Here is the summary of changes.

You are about to add 85 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@JesseLovelace JesseLovelace changed the title (feat) Copy all storage samples from java-docs-samples feat: Copy all storage samples from java-docs-samples Feb 16, 2022
@BenWhitehead BenWhitehead changed the title feat: Copy all storage samples from java-docs-samples docs: Copy all storage samples from java-docs-samples Feb 17, 2022
@BenWhitehead
Copy link
Collaborator

I changed the PR type to docs so it doesn't cause a minor version bump.

@BenWhitehead
Copy link
Collaborator

In the ultimate commit comment I think it'd be good to include a link to the SHA that the samples were imported from. Just in case we ever need to try and backtrace something.

@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 3, 2022
@JesseLovelace JesseLovelace added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
@JesseLovelace JesseLovelace marked this pull request as ready for review March 4, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants