fix: add gccl-invocation-id interceptor #1309

frankyn · 2022-03-25T16:11:14Z

Joint effort with @BenWhitehead who is the author of the original design, thank you Ben!

Ensure the tests and linter pass
Add option to disable the invocation id
Make sure this header isn't passed in for signed URLs
Appropriate docs were updated (if necessary)

…ation attempts across multiple rpcs TODOs 1. Add option to StorageOptions to allow disabling 2. Add some unit tests to verify behavior independent of reading full request logs

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…e clear themselves Also fixed a typo which meant that the v4 url wasn't being tested, however now the v4 url is failing to validate and I'm not sure how to fix the url.

frankyn · 2022-03-28T20:16:15Z

google-cloud-storage/src/test/java/com/google/cloud/storage/spi/v1/HttpRpcContextTest.java

-    HttpRpcContext testContext = new HttpRpcContext(testUUIDSupplier);
-    testContext.newInvocationId();
-    assertEquals(testUUIDSupplier.get(), testContext.getInvocationId());
+    UUID uuid = UUID.fromString("28220dff-1e8b-4770-9e10-022c2a99d8f3");


per-discussion with @BenWhitehead: the test prior was using the supplier instance "testUUIDSupplier.get()" caused a mutation to the state of the Supplier but passes because there is only one UUID. Instead we should not test the Supplier<> and only test HttpRpcContext(), hence the update relies on testContext rather than accessing Supplier<> directly.

google-cloud-storage/src/main/java/com/google/cloud/storage/StorageOptions.java

google-cloud-storage/src/test/java/com/google/cloud/storage/StorageImplTest.java

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

BenWhitehead

We also need to add the following to private Builder(StorageOptions options) so we ensure we carry through any value set previously.

      this.storageIncludeInvocationId = options.includeInvocationId;

google-cloud-storage/src/main/java/com/google/cloud/storage/StorageOptions.java

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…apis/java-storage into invocation-id-interceptor

BenWhitehead and others added 10 commits February 16, 2022 12:14

fix: add gccl-invocation-id to all requests to allow identifying oper…

b2ee6f4

…ation attempts across multiple rpcs TODOs 1. Add option to StorageOptions to allow disabling 2. Add some unit tests to verify behavior independent of reading full request logs

fix: enforce single initializing thread for HttpRpcContext#getInstance

6111ab9

fix: dependency builds

42e76f1

add tests for HttpRpcContext

e136fd4

🦉 Updates from OwlBot post-processor

446d68c

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

revert changes to getServiceAccount

4b64a0c

Merge branch 'main' into invocation-id-interceptor

c730c84

revert dep

7941981

add copyright

130d9c0

revert revert dep

1a4cc3e

product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Mar 26, 2022

Frank Natividad and others added 2 commits March 28, 2022 10:43

handle SignedURLs

7f069b7

🦉 Updates from OwlBot post-processor

7f5ee6e

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

BenWhitehead changed the title ~~feat: Invocation id interceptor~~ fix: add gccl-invocation-id interceptor Mar 28, 2022

BenWhitehead and others added 4 commits March 28, 2022 16:08

chore: refactor HttpRpcContextTest to try and help make the tests mor…

daf51fe

…e clear themselves Also fixed a typo which meant that the v4 url wasn't being tested, however now the v4 url is failing to validate and I'm not sure how to fix the url.

address v4 sig test failure

25532f0

lint

708e21a

allow disablement of invocation id

379c920

frankyn commented Mar 28, 2022

View reviewed changes

frankyn marked this pull request as ready for review March 28, 2022 21:22

frankyn requested review from a team as code owners March 28, 2022 21:22

BenWhitehead requested changes Mar 28, 2022

View reviewed changes

Frank Natividad and others added 3 commits March 28, 2022 14:59

address feedback

775a754

🦉 Updates from OwlBot post-processor

d8532f4

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

reduce complexity of invocationId option with default value

340c7da

frankyn requested a review from BenWhitehead March 29, 2022 18:17

BenWhitehead requested changes Mar 29, 2022

View reviewed changes

frankyn and others added 2 commits March 29, 2022 11:43

Apply suggestions from code review

1ddd7e6

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>

🦉 Updates from OwlBot post-processor

a0b8c83

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Frank Natividad added 2 commits March 29, 2022 11:50

address feedback

6d84027

address feedback

8af9d0b

frankyn requested a review from BenWhitehead March 29, 2022 19:59

BenWhitehead approved these changes Apr 1, 2022

View reviewed changes

BenWhitehead added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 1, 2022

frankyn and others added 3 commits April 1, 2022 14:21

Merge branch 'main' into invocation-id-interceptor

21d43d4

🦉 Updates from OwlBot post-processor

4208c08

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'invocation-id-interceptor' of https://github.com/google…

52e3f2c

…apis/java-storage into invocation-id-interceptor

BenWhitehead merged commit 335c267 into main Apr 1, 2022

BenWhitehead deleted the invocation-id-interceptor branch April 1, 2022 21:32

release-please bot mentioned this pull request Apr 1, 2022

chore(main): release 2.6.1 #1333

Merged

release-please bot mentioned this pull request Aug 10, 2022

chore(main): release 2.11.4 #1564

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add gccl-invocation-id interceptor #1309

fix: add gccl-invocation-id interceptor #1309

Uh oh!

frankyn commented Mar 25, 2022 •

edited

Loading

Uh oh!

frankyn Mar 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenWhitehead left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: add gccl-invocation-id interceptor #1309

fix: add gccl-invocation-id interceptor #1309

Uh oh!

Conversation

frankyn commented Mar 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frankyn Mar 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BenWhitehead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

frankyn commented Mar 25, 2022 •

edited

Loading