KEMBAR78
fix(java): add service account email to Native Image testing kokoro job by mpeddada1 · Pull Request #1348 · googleapis/java-storage · GitHub
Skip to content

Conversation

@mpeddada1
Copy link
Contributor

This PR reduces the discrepancy between the standard Java and Native Image kokoro job. It should also fix the following error:

java.lang.AssertionError: Unable to determine service account email
	at com.google.cloud.storage.it.ITStorageTest.testHmacKey(ITStorageTest.java:2472)

@mpeddada1 mpeddada1 requested review from a team as code owners April 8, 2022 18:43
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/presubmit/graalvm-native.cfg

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Apr 8, 2022
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Apr 8, 2022
@BenWhitehead
Copy link
Collaborator

@mpeddada1 You'll need to add an exclude to owlbot.py so it doesn't clobber your update. We had to do the same thing for integration and samples

'.kokoro/presubmit/integration.cfg',

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Apr 11, 2022
@mpeddada1
Copy link
Contributor Author

Thank you @BenWhitehead!

@BenWhitehead BenWhitehead merged commit 9f76fcc into main Apr 12, 2022
@BenWhitehead BenWhitehead deleted the native-kokoro branch April 12, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants