feat: add new dedupe utility method to Option classes #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
BenWhitehead
changed the title
frankyn
reviewed
Jun 15, 2023
When providing options duplicates are not allowed, however there are times when you might end up providing two options which would collide. These new utility methods encapsulate the logic necessary to deduplicate any overlap wil returing an array which can be passed directly to the respective operation method. `dedupe` utility methods added to each of the following Option classes: * Storage.BlobGetOption.dedupe(); * Storage.BlobListOption.dedupe(); * Storage.BlobSourceOption.dedupe(); * Storage.BlobTargetOption.dedupe(); * Storage.BlobWriteOption.dedupe(); * Storage.BucketGetOption.dedupe(); * Storage.BucketListOption.dedupe(); * Storage.BucketSourceOption.dedupe(); * Storage.BucketTargetOption.dedupe(); * Storage.CreateHmacKeyOption.dedupe(); * Storage.DeleteHmacKeyOption.dedupe(); * Storage.GetHmacKeyOption.dedupe(); * Storage.ListHmacKeysOption.dedupe(); * Storage.UpdateHmacKeyOption.dedupe(); * Bucket.BlobTargetOption.dedupe(); * Bucket.BlobWriteOption.dedupe(); * Bucket.BucketSourceOption.dedupe(); * Blob.BlobSourceOption.dedupe(); There are overloads which accept a collection or array in addition to varargs.
BenWhitehead
force-pushed
the
dedupe-options
branch
from
0d02e6c to
9145147
Compare
BenWhitehead
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing options duplicates are not allowed, however there are times when you might end up providing two options which would collide. These new utility methods encapsulate the logic necessary to deduplicate any overlap wil returing an array which can be passed directly to the respective operation method.
dedupeutility methods added to each of the following Option classes: