fix: update gRPC writeAndClose to only set finish_write on the last message #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage As of 2.26.0 it would set finish_write on every message emitted by writeAndClose Update ITGapicUnbufferedWritableByteChannelTest to also include checksum values in its requests/responses.
product-auto-label
bot
added
size: m
frankyn
approved these changes
Aug 11, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 2.26.0 it would set finish_write on every message emitted by writeAndClose
Update ITGapicUnbufferedWritableByteChannelTest to also include checksum values in its requests/responses.