KEMBAR78
fix: fix JSON read handling when socket broken resulting in partial bytes copied by BenWhitehead · Pull Request #2303 · googleapis/java-storage · GitHub
Skip to content

Conversation

@BenWhitehead
Copy link
Collaborator

Add integration test with testbench to force failure during read

Fixes #2301

@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Nov 14, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner November 14, 2023 18:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Nov 14, 2023
…ytes copied

Add integration test with testbench to force failure during read

Update retry conformance tests to assert full byte content when read through reader

Fixes #2301
Copy link
Contributor

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenWhitehead BenWhitehead merged commit d4bfcf0 into main Nov 14, 2023
@BenWhitehead BenWhitehead deleted the fix-2301 branch November 14, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCP cloud storage downloaded file corruption

2 participants