KEMBAR78
fix: update Grpc Retry Conformance after new additions to testbench by BenWhitehead · Pull Request #2309 · googleapis/java-storage · GitHub
Skip to content

fix: update Grpc Retry Conformance after new additions to testbench #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: update Grpc Retry Conformance after new additions to testbench #2309

merged 1 commit into from
Apr 17, 2024

Conversation

@BenWhitehead
Copy link
Collaborator

@BenWhitehead BenWhitehead commented Nov 17, 2023 •
edited
Loading

  • Grpc DeleteBucket idempotent inline with existing http
  • Grpc DeleteHmacKey idempotent inline with existing http
  • GrpcStorageImpl#create(BlobInfo, InputStream) changed from resumable upload to single-shot upload inline with http
  • GrpcStorageImpl#delete(String) update error handling only 404 translates to false inline with http
  • GrpcStorageImpl#writer(BlobInfo) await start resumable write for error reporting inline with http
  • Remove ITGrpcStorageImplUploadRetryTest now that we have grpc retry conformance tests which are more comprehensive

grpc setIamPolicy tests are currently disabled and will be enabled in a follow-up PR

@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Nov 17, 2023
@BenWhitehead BenWhitehead requested a review from a team as a code owner November 17, 2023 19:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Nov 17, 2023
@frankyn
Copy link
Contributor

frankyn commented Nov 17, 2023

oh no, there's a out of memory issue happening;

@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2023
@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
@BenWhitehead BenWhitehead force-pushed the enable-grpc-retry-conformance-tests branch from 1606b11 to 31936ef Compare April 17, 2024 21:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Apr 17, 2024
@BenWhitehead BenWhitehead changed the title test: enable gRPC retry conformance tests fix: update Grpc Retry Conformance after new additions to testbench Apr 17, 2024
@BenWhitehead BenWhitehead force-pushed the enable-grpc-retry-conformance-tests branch from 31936ef to 03e6c1a Compare April 17, 2024 21:26
@BenWhitehead BenWhitehead requested a review from frankyn April 17, 2024 21:28
@BenWhitehead BenWhitehead force-pushed the enable-grpc-retry-conformance-tests branch from 03e6c1a to 0612172 Compare April 17, 2024 22:14
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 17, 2024
@BenWhitehead BenWhitehead merged commit 09043c5 into main Apr 17, 2024
@BenWhitehead BenWhitehead deleted the enable-grpc-retry-conformance-tests branch April 17, 2024 22:48
@release-please release-please bot mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BenWhitehead @frankyn @yoshi-kokoro @sydney-munro