KEMBAR78
docs: Create Samples for transfer manager by sydney-munro · Pull Request #2492 · googleapis/java-storage · GitHub
Skip to content

docs: Create Samples for transfer manager #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 12, 2024
Merged

docs: Create Samples for transfer manager #2492

merged 9 commits into from
Apr 12, 2024

Conversation

@sydney-munro
Copy link
Contributor

@sydney-munro sydney-munro commented Apr 8, 2024 •
edited
Loading

Samples for the upload many operations only. Will do chunked once Parallel Composite Upload is complete.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 8, 2024
@snippet-bot
Copy link

snippet-bot bot commented Apr 8, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 8, 2024
@sydney-munro sydney-munro requested review from a team as code owners April 8, 2024 17:54
@sydney-munro sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label Apr 8, 2024
BenWhitehead
BenWhitehead approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from java side, probably want to get andrew to review for the general review.

@sydney-munro sydney-munro requested a review from andrewsg April 11, 2024 22:34
andrewsg
andrewsg approved these changes Apr 12, 2024
View reviewed changes
Copy link

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sydney-munro sydney-munro merged commit e2030b2 into main Apr 12, 2024
@sydney-munro sydney-munro deleted the tm-sample branch April 12, 2024 21:08
@release-please release-please bot mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

+1 more reviewer

@andrewsg andrewsg andrewsg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sydney-munro @andrewsg @BenWhitehead