KEMBAR78
feat: Transfer Manager ParallelCompositeUploads by sydney-munro · Pull Request #2494 · googleapis/java-storage · GitHub
Skip to content

feat: Transfer Manager ParallelCompositeUploads #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 11, 2024
Merged

feat: Transfer Manager ParallelCompositeUploads #2494

merged 10 commits into from
Apr 11, 2024

Conversation

@sydney-munro
Copy link
Contributor

@sydney-munro sydney-munro commented Apr 10, 2024 •
edited
Loading

This implements ParallelCompositeUploads(PCU) in Transfer Manager.

ParallelCompositeUpload in Transfer Manager is an opt-in feature, customers will have to update their config to allow Transfer Manager to perform PCU operations on their behalf. Transfer Manager will only do this if the following conditions are met:

  • The customer has set allowParallelCompositeUpload to true
  • The file to be uploaded is 4 * the buffer per worker size
  • The customer has specified enough threads that ParallelCompositeUpload can be of benefit while still cuing other work.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Apr 10, 2024
@sydney-munro sydney-munro marked this pull request as ready for review April 11, 2024 19:24
@sydney-munro sydney-munro requested a review from a team as a code owner April 11, 2024 19:24
@sydney-munro sydney-munro requested a review from a team as a code owner April 11, 2024 20:31
@sydney-munro sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label Apr 11, 2024
BenWhitehead
BenWhitehead requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cleanup item related to options.

Can you also purge out the owlbot commit, it's adding noise to the PR unrelated to your change.

@sydney-munro sydney-munro merged commit 8b54549 into main Apr 11, 2024
@sydney-munro sydney-munro deleted the tm-pcu branch April 11, 2024 22:43
@release-please release-please bot mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sydney-munro @BenWhitehead