-
Notifications
You must be signed in to change notification settings - Fork 85
Closed
Labels
api: storageIssues related to the googleapis/java-storage API.Issues related to the googleapis/java-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
Classes defined in PostPolictyV4.java are not as perfect as they can be.
Enhancements and bugs are listed below:
class PostPolicyV4
- the class description is stingy, need to put more words and point to usage example
- public methods miss Javadoc
- no verification for given URL string is a valid URL
- BUG:
getFields()returns the map as is, so one can modify PostPolicyV4 objects after creation
(suggested fix: makefieldsimmutable)
class PostPolicyV4.PostFieldsV4
- BUG: public method
getFieldsMap()returns map that allows to alter PostFieldsV4 instances without Builder (no control)
(suggested fix: deprecate method getFieldsMap(), make the map immutable, define getters)
class PostPolicyV4.PostConditionsV4
- BUG
getConditions()returns mutable Set - BUG
getConditions()exposes non public classPostPolicyV4.ConditionV4
(suggested fix: makePostPolicyV4.ConditionV4public, makeconditionsimmutable)
Metadata
Metadata
Assignees
Labels
api: storageIssues related to the googleapis/java-storage API.Issues related to the googleapis/java-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.