KEMBAR78
test: retry conformance tests/fixes 1 by BenWhitehead · Pull Request #1031 · googleapis/java-storage · GitHub
Skip to content

Conversation

@BenWhitehead
Copy link
Collaborator

test: fix notifications tests erroring
test: fix objects.get tests
  • Fix misconfigured setup
  • Fix some method invocations using metageneration instead of generation
  • Update State to clear an entry if provided a null value rather than throwing an exception (this is necessary for tear down steps to clean up).
test: update testNamesWhichShouldSucceed.txt

* Fix missconfigured setup
* Fix some method invocations using metageneration instead of generation
* Update State to clear an entry if provided a null value rather than throwing an exception (this is necessary for tear down steps to clean up).
@BenWhitehead BenWhitehead requested review from a team as code owners September 21, 2021 03:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Sep 21, 2021
@BenWhitehead BenWhitehead merged commit 3df8cc3 into googleapis:master Sep 21, 2021
@BenWhitehead BenWhitehead deleted the retry-conformance-tests/fixes-1 branch September 21, 2021 15:59
@BenWhitehead BenWhitehead added this to the Retry Conformance Project milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants