KEMBAR78
revert opencensus 0.25.0 to 0.24.0 by frankyn · Pull Request #145 · googleapis/java-storage · GitHub
Skip to content

revert opencensus 0.25.0 to 0.24.0 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Included google() repository in gradle build
merged 1 commit into from
Feb 26, 2020
Merged

revert opencensus 0.25.0 to 0.24.0 #145

merged 1 commit into from
Feb 26, 2020

Conversation

@frankyn
Copy link
Contributor

@frankyn frankyn commented Feb 25, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2020
@codecov
Copy link

codecov bot commented Feb 25, 2020 •
edited
Loading

Codecov Report

Merging #145 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #145      +/-   ##
============================================
+ Coverage     63.58%   63.64%   +0.06%     
  Complexity      539      539              
============================================
  Files            30       30              
  Lines          4731     4731              
  Branches        426      426              
============================================
+ Hits           3008     3011       +3     
+ Misses         1565     1562       -3     
  Partials        158      158
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/storage/testing/RemoteStorageHelper.java 64.46% <0%> (+2.47%) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91ecfe...548fbd2. Read the comment docs.

elharo
elharo reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hold off until this afternoon's meeting and make a decision about which OpenCensus version we want to use across the orbit?

@frankyn frankyn added the status: blocked Resolving the issue is dependent on other work. label Feb 25, 2020
@frankyn
Copy link
Contributor Author

frankyn commented Feb 25, 2020

Don't merge until we get consensus on version for opencensus.

@elharo
Copy link
Contributor

elharo commented Feb 26, 2020

Decision was to stick with the version gRPC and http-java-client use, which, for now, is 0.24.0. If they update first, we'll update.

@elharo elharo changed the title revert opencensus 0.24.0 revert opencensus 0.25.0 to 0.24.0 Feb 26, 2020
@elharo elharo merged commit 95e49a2 into master Feb 26, 2020
@elharo elharo deleted the revert-opencensus branch February 26, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@elharo elharo elharo left review comments

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frankyn @elharo @stephaniewang526 @googlebot