Included google() repository in gradle build #157
Conversation
googlebot
added
the
cla: yes
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: no
|
@googlebot I fixed it. |
…ory for version 1.104+
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: yes
yoshi-kokoro
removed
the
kokoro:run
| ```Groovy | ||
| repositories { | ||
| google() //this is required from version 1.104 onwards | ||
| //other repositories |
There was a problem hiding this comment.
Do you need to add central() explicitly too?
There was a problem hiding this comment.
Yes. I added the additional part that would be required
There was a problem hiding this comment.
you need to put central here too
There was a problem hiding this comment.
@elharo should I make any more changes?
README.md
Outdated
| If you are using Gradle, add this to your dependencies | ||
| ```Groovy | ||
| repositories { | ||
| google() //this is required from version 1.104 onwards |
There was a problem hiding this comment.
comment can be removed. This won't be necessary in the near future.
There was a problem hiding this comment.
Sure. (when I make this change.. is it okay to amend and force push or a separate commit)?
There was a problem hiding this comment.
Just make multiple commits and push again. I'll squash when it's merged.
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
============================================
- Coverage 63.46% 63.40% -0.07%
Complexity 537 537
============================================
Files 30 30
Lines 4752 4752
Branches 427 427
============================================
- Hits 3016 3013 -3
- Misses 1576 1579 +3
Partials 160 160
Continue to review full report at Codecov.
|
athakor
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sudipidus
force-pushed
the
master
branch
2 times, most recently
from
906c23b to
2184191
Compare
yoshi-kokoro
removed
the
kokoro:run
6 participants
Fixes #<156> (it's a good idea to open an issue first for context and/or discussion)
I think it's advisable to have this info in the readme itself since it's required only for version 1.104 and upwards.