KEMBAR78
samples: adding preconditions to some of the samples by sydney-munro · Pull Request #1718 · googleapis/java-storage · GitHub
Skip to content

samples: adding preconditions to some of the samples #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 31, 2022
Merged

samples: adding preconditions to some of the samples #1718

merged 7 commits into from
Oct 31, 2022

Conversation

@sydney-munro
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Oct 18, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 18, 2022
@sydney-munro sydney-munro marked this pull request as ready for review October 18, 2022 23:13
BenWhitehead
BenWhitehead requested changes Oct 19, 2022
View reviewed changes
@BenWhitehead
Copy link
Collaborator

LGTM, get someone from samples reviewers to give it a once over, then merge away!

@sydney-munro sydney-munro requested review from a team, Neenu1995, Shabirmean and lesv and removed request for Neenu1995, Shabirmean and lesv October 21, 2022 18:42
@sydney-munro sydney-munro added the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 28, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 28, 2022
@sydney-munro sydney-munro merged commit 9ba14b7 into main Oct 31, 2022
@sydney-munro sydney-munro deleted the preconditions branch October 31, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

@frankyn frankyn Awaiting requested review from frankyn

+1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvg kurtisvg

Labels

api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sydney-munro @BenWhitehead @kurtisvg