feat: First Pass Implementation of UploadMany #1922
Conversation
product-auto-label
bot
added
size: l
sydney-munro
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
sydney-munro
force-pushed
the
transfer-impl
branch
from
3f4b29e to
53a17bd
Compare
sydney-munro
force-pushed
the
transfer-impl
branch
from
53a17bd to
992943e
Compare
| public @NonNull UploadJob uploadFiles(List<Path> files, ParallelUploadConfig opts) { | ||
| List<Future<UploadResult>> uploadTasks = new ArrayList<>(); | ||
| for (Path file : files) { | ||
| if (Files.isDirectory(file)) throw new IllegalStateException("Directories are not supported"); |
There was a problem hiding this comment.
just to clarify -- we plan to support Directory upload in the future?
There was a problem hiding this comment.
The idea is that the api will just accept file paths but we will "support" directories in the samples by showing the customers how to generate that list themselves from a directory.
There was a problem hiding this comment.
Are we planning to have TransferManagerUtils be public to consumers? If so, should we consider a method like TransferManagerUtils.getFileListForDirectory(Path directory) that does it for you?
| return uploadWithoutChunking(); | ||
| } | ||
|
|
||
| private UploadResult uploadWithoutChunking() throws IOException { |
There was a problem hiding this comment.
Once we support MPU, it would be great if we could determine how (single shot vs resumable vs MPU) to upload based on the object size.
There was a problem hiding this comment.
yes, I think this is the goal. also throughput based. If we are uploading super fast no sense in spending the overhead to split the work.
sydney-munro
force-pushed
the
transfer-impl
branch
from
b97db6d to
e4540a9
Compare
3 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.