KEMBAR78
ci: unmanaged dependency check by suztomo · Pull Request #2396 · googleapis/java-storage · GitHub
Skip to content

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Feb 6, 2024

This check avoids accidentally adding 3rd party dependencies. This is one of the items listed in go/cloud-sdk-java-dependency-governance-design. Sydney has reviewed this.

b/320678476


Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

This check avoids accidentally adding 3rd party dependencies
go/cloud-sdk-java-dependency-governance-design.
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Feb 6, 2024
@suztomo
Copy link
Member Author

suztomo commented Feb 6, 2024

Unmanaged dependency check / unmanaged_dependency_check (pull_request) Successful.

@suztomo suztomo requested a review from sydney-munro February 6, 2024 22:53
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/sync-repo-settings.yaml

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@suztomo
Copy link
Member Author

suztomo commented Feb 6, 2024

@sydney-munro Hi Sydney, this is the one of the steps in go/cloud-sdk-java-dependency-governance-design. Would you review this?

@suztomo suztomo marked this pull request as ready for review February 7, 2024 02:11
@suztomo suztomo requested review from a team as code owners February 7, 2024 02:11
@sydney-munro sydney-munro merged commit b7f6eb3 into main Feb 8, 2024
@sydney-munro sydney-munro deleted the unmanaged_dependency_check branch February 8, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants