KEMBAR78
chore: fix samples pom.xml issues by BenWhitehead · Pull Request #2660 · googleapis/java-storage · GitHub
Skip to content

Conversation

@BenWhitehead
Copy link
Collaborator

@BenWhitehead BenWhitehead commented Aug 5, 2024

  • Close dependencies element for storage_install_with_bom
  • Remove release please comment for storage control from storage_install_without_bom. Instead, allow renovate-bot to update when the version is available in maven central.
  • remove duplicate declaration of google-cloud-storage-control in install-without-bom/pom.xml

* Close dependency element for `storage_install_with_bom`
* Remove release please comment for storage control from `storage_install_without_bom`. Instead, allow renovate-bot to update when the version is available in maven central.
* remove duplicate declaration of `google-cloud-storage-control` in install-without-bom/pom.xml
@BenWhitehead BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Aug 5, 2024
@BenWhitehead BenWhitehead requested review from a team as code owners August 5, 2024 18:49
@snippet-bot
Copy link

snippet-bot bot commented Aug 5, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/install-without-bom/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Aug 5, 2024
@BenWhitehead BenWhitehead merged commit 48e7a4c into main Aug 5, 2024
@BenWhitehead BenWhitehead deleted the fix-sample-xml branch August 5, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants