feat: allow specifying an expected object size for resumable operations. #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
| && ed.getErrorInfo() != null | ||
| && ed.getErrorInfo().getReason().equals("GRPC_MISMATCHED_UPLOAD_SIZE"))) { | ||
| clientDetectedError( | ||
| ResumableSessionFailureScenario.SCENARIO_5.toStorageException( |
There was a problem hiding this comment.
can we get some comments around what Scenario 5 is to make it easier to read?
There was a problem hiding this comment.
oh i see this was there before as well. my apologies. that can be a followup.
There was a problem hiding this comment.
ResumableSessionFailureScenario is an enum that is shared by several of our upload implementations and defines the types of failure scenarios that can happen when processing an upload request.
SCENARIO_5 is client side data loss detected
sydney-munro
approved these changes
Aug 23, 2024
google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
Outdated
Show resolved
Hide resolved
| && ed.getErrorInfo() != null | ||
| && ed.getErrorInfo().getReason().equals("GRPC_MISMATCHED_UPLOAD_SIZE"))) { | ||
| clientDetectedError( | ||
| ResumableSessionFailureScenario.SCENARIO_5.toStorageException( |
There was a problem hiding this comment.
oh i see this was there before as well. my apologies. that can be a followup.
Update resumable upload failure detection to be more specific about classifying a request as SCENARIO_5 Fixes #2511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update resumable upload failure detection to be more specific about classifying a request as SCENARIO_5
Fixes #2511