KEMBAR78
Revert "feat: expose all the methods of notification" by frankyn · Pull Request #393 · googleapis/java-storage · GitHub
Skip to content

Revert "feat: expose all the methods of notification" #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2020
Merged

Revert "feat: expose all the methods of notification" #393

merged 1 commit into from
Jun 25, 2020

Conversation

@frankyn
Copy link
Contributor

@frankyn frankyn commented Jun 25, 2020

@frankyn frankyn requested a review from athakor June 25, 2020 15:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #393 into master will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #393      +/-   ##
============================================
- Coverage     63.61%   63.13%   -0.49%     
+ Complexity      632      601      -31     
============================================
  Files            33       32       -1     
  Lines          5222     5078     -144     
  Branches        498      481      -17     
============================================
- Hits           3322     3206     -116     
+ Misses         1730     1708      -22     
+ Partials        170      164       -6
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/cloud/storage/Storage.java 80.90% <ø> (ø) 0.00 <0.00> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 80.52% <ø> (+0.28%) 131.00 <0.00> (-4.00) ⬆️
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.52% <ø> (+0.01%) 1.00 <0.00> (ø)
...ogle/cloud/storage/spi/v1/HttpStorageRpcSpans.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/com/google/cloud/storage/spi/v1/StorageRpc.java 64.86% <ø> (ø) 0.00 <0.00> (ø)
...ogle/cloud/storage/testing/StorageRpcTestBase.java 97.95% <ø> (-0.05%) 48.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfc0cb...b951cad. Read the comment docs.

@dmitry-fa dmitry-fa self-requested a review June 25, 2020 15:38
athakor
athakor approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@athakor athakor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankyn Good catch also i missed it there must be a wrapper instead of underlying Google API client object model

@frankyn frankyn merged commit 3e02b9c into master Jun 25, 2020
@frankyn frankyn deleted the revert-141-storage-138 branch June 25, 2020 16:23
@release-please release-please bot mentioned this pull request Jun 25, 2020
Merged
@athakor athakor mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmitry-fa dmitry-fa Awaiting requested review from dmitry-fa

1 more reviewer

@athakor athakor athakor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frankyn @athakor @googlebot