KEMBAR78
fix: make sure to pass selectedFields to tabledata.list method by alvarowolfx · Pull Request #1449 · googleapis/nodejs-bigquery · GitHub
Skip to content

Conversation

alvarowolfx
Copy link
Contributor

@alvarowolfx alvarowolfx commented Mar 14, 2025

A regression got introduce in PR #1437, where a user informed options.selectedField is deleted and not sent to the tabledata.list API.

Also this PR avoid mutations on the selectedFields parameter across the SDK, which solves other issues reported on #1433. More tests where added to cover cases with array and deeply nested objects.

Fixes #1433

@alvarowolfx alvarowolfx requested review from a team as code owners March 14, 2025 20:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Mar 14, 2025
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but just pin that promisify version for now to fix ci

@alvarowolfx
Copy link
Contributor Author

blocked by #1450

@alvarowolfx alvarowolfx merged commit 206aff9 into main Mar 17, 2025
18 checks passed
@alvarowolfx alvarowolfx deleted the fix-selected-field-mutation branch March 17, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in table.getRows when using different selectedFields in consecutive calls

2 participants