feat: updates to fastpath query execution #2268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR plumbs in config support for max_slots, which is an allowlisted preview feature.
product-auto-label
bot
added
size: m
chalmerlowe
previously approved these changes
Aug 26, 2025
| if value is not None: | ||
| self._properties["maxSlots"] = str(value) | ||
| else: | ||
| self._properties.pop("maxSlots", None) |
There was a problem hiding this comment.
#QUESTION
What is the impetus for .pop()?
If value is None, delete the key: value pair entirely?
I know we also did it with jobTimeoutMs and I don't get it there either.
There was a problem hiding this comment.
#QUESTION
What is the impetus for
.pop()?If
valueisNone, delete thekey: valuepair entirely? I know we also did it withjobTimeoutMsand I don't get it there either.
It's the easier one liner. We either need to check for the key existence explicitly, or wrap the delete in a try...except block to handle the cases where you're setting the None value and the key doesn't yet exist in the dict. Happy to swap to one of these if you prefer.
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
This was referenced Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates query handling to allow base config properties like job timeout, reservation, and a preview max slots field to leverage the faster path (e.g. using jobs.query rather than jobs.insert).