KEMBAR78
fix: Allow protobuf 6.x by parthea · Pull Request #2142 · googleapis/python-bigquery · GitHub
Skip to content

fix: Allow protobuf 6.x #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 18, 2025
Merged

fix: Allow protobuf 6.x #2142

merged 8 commits into from
Mar 18, 2025

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 7, 2025 •
edited
Loading

See https://pypi.org/project/protobuf/6.30.0/
See googleapis/gapic-generator-python#2347 for removing dev in setup.py

Adding do not merge as it's not clear if protobuf 6.x is being tested in the prerelease_deps nox session.

python-bigquery/noxfile.py

Lines 358 to 364 in f8572dd

@nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
@_calculate_duration
def prerelease_deps(session):
"""Run all tests with prerelease versions of dependencies installed.
https://github.com/googleapis/python-bigquery/issues/95
"""

BEGIN_COMMIT_OVERRIDE
feat: add support for Python 3.13
fix: Allow protobuf 6.x
END_COMMIT_OVERRIDE

Towards b/400901178

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 7, 2025
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed size: s Pull request size is small. labels Mar 7, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 7, 2025
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 7, 2025
@parthea
Copy link
Contributor Author

parthea commented Mar 7, 2025

This still requires more work to ensure that the latest pre-release versions are installed.

@parthea parthea mentioned this pull request Mar 10, 2025
Merged
1 task
@parthea parthea self-assigned this Mar 17, 2025
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 18, 2025
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 18, 2025
@parthea
Copy link
Contributor Author

parthea commented Mar 18, 2025

Wait for cl/738005624

@parthea parthea removed their assignment Mar 18, 2025
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 18, 2025
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 18, 2025
@parthea parthea self-assigned this Mar 18, 2025
@parthea parthea marked this pull request as ready for review March 18, 2025 16:07
@parthea parthea requested review from a team as code owners March 18, 2025 16:07
@parthea parthea requested a review from PhongChuong March 18, 2025 16:07
@parthea parthea assigned chalmerlowe and unassigned parthea Mar 18, 2025
chalmerlowe
chalmerlowe approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea merged commit 0842aa1 into main Mar 18, 2025
17 of 23 checks passed
@parthea parthea deleted the allow-protobuf-6 branch March 18, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@PhongChuong PhongChuong Awaiting requested review from PhongChuong PhongChuong is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea @chalmerlowe @kokoro-team