KEMBAR78
fix: correct notification error message by tritone · Pull Request #1290 · googleapis/python-storage · GitHub
Skip to content

Conversation

@tritone
Copy link
Contributor

@tritone tritone commented Jun 17, 2024

To create a new notification, the notification_id field must be set to None. Update the error message to clarify this.

Fixes #1289

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

To create a new notification, the notification_id field must be
set to None. Update the error message to clarify this.

Fixes googleapis#1289
@tritone tritone requested review from a team as code owners June 17, 2024 15:13
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Jun 17, 2024
@andrewsg
Copy link
Contributor

Thank you! Please feel free to merge directly, or ask me to merge, when you're ready.

@andrewsg andrewsg added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 17, 2024
@tritone tritone merged commit 1cb977d into googleapis:main Jun 17, 2024
@tritone tritone deleted the notification-err branch June 17, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message when creating notifications while specifying a notification ID.

3 participants