fix: send entire object checksums via upload methods #1561
Merged
+268
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1541 : Send entire object checksums via upload methods and remove it from Object properties.
In recent release, v3.3.1 this library provided an option for users to specify entire object checksum before performing resumable upload. It introduced the bug Version 3.3.1 has broken blob.upload_from_file(file_obj) with error: Provided CRC32C xMvOLw== doesn't match calculated CRC32C ObqI+Q== #1541
This PR is fixing it by providing the option to specify entire object checksum via upload methods -
upload_from_string,upload_from_fileandupload_from_filename.Note: Ability to specify entire upload checksum is applicable only for Resumable Uploads , which in this library is applicable for uploads of object greater than 8 MiB