KEMBAR78
samples: add samples for move api to rename an object by Pulkit0110 · Pull Request #1505 · googleapis/python-storage · GitHub
Skip to content

samples: add samples for move api to rename an object #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 17, 2025
Merged

samples: add samples for move api to rename an object #1505

merged 7 commits into from
Jul 17, 2025

Conversation

@Pulkit0110
Copy link
Member

Add samples for move api to rename an object.

@Pulkit0110 Pulkit0110 requested review from a team as code owners July 10, 2025 14:41
@Pulkit0110 Pulkit0110 requested a review from parthea July 10, 2025 14:41
@snippet-bot
Copy link

snippet-bot bot commented Jul 10, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Jul 10, 2025
@Pulkit0110 Pulkit0110 requested a review from chandra-siri July 10, 2025 14:41
chandra-siri
chandra-siri requested changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@chandra-siri chandra-siri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR heading should be samples: <Title>

@Pulkit0110
Copy link
Member Author

PR heading should be samples: <Title>

as per https://www.conventionalcommits.org/en/v1.0.0/#summary, there's no samples title in conventional commit

chandra-siri
chandra-siri previously approved these changes Jul 16, 2025
View reviewed changes
@Pulkit0110 Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 16, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 16, 2025
@dandhlee
Copy link
Contributor

nit: docs triggers a semver - patch version bump (1.0.0 to 1.0.1) and will be included in the release notes of the library. If that is intended then fine to leave as is, otherwise use chore(docs) or chore(samples).

dandhlee
dandhlee reviewed Jul 17, 2025
View reviewed changes
dandhlee
dandhlee approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing for Python samples style.

@Pulkit0110 Pulkit0110 changed the title docs: add samples for move api to rename an object samples: add samples for move api to rename an object Jul 17, 2025
@Pulkit0110 Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 17, 2025
@Pulkit0110 Pulkit0110 merged commit edde950 into googleapis:main Jul 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandra-siri chandra-siri chandra-siri approved these changes

@dandhlee dandhlee dandhlee approved these changes

@parthea parthea Awaiting requested review from parthea parthea is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@chandra-siri chandra-siri

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pulkit0110 @dandhlee @chandra-siri