-
Notifications
You must be signed in to change notification settings - Fork 71
Description
Is your feature request related to a problem? Please describe.
In Storage SDK (java-storage); we are looking at introducing a new zero copy response marshaler for ReadObject request. It currently can only be configured by recreating the callable which replicates code in the GAPIC generated client library. Our main concern is that it deviates from potential future improvements which would need to be ported over to one-off callable implementations.
// Redacted from constructor where this is being created in the prototype linked below.
serverStreamingCallable =
new GrpcStorageCallableFactory()
.createServerStreamingCallable(
readObjectTransportSettings,
storageClient.getSettings().readObjectSettings(),
ClientContext.create(storageClient.getSettings()));
// ....
static final MethodDescriptor<ReadObjectRequest, ReadObjectResponse> readObjectMethodDescriptor =
MethodDescriptor.<ReadObjectRequest, ReadObjectResponse>newBuilder()
.setType(MethodDescriptor.MethodType.SERVER_STREAMING)
.setFullMethodName("google.storage.v2.Storage/ReadObject")
.setRequestMarshaller(ProtoUtils.marshaller(ReadObjectRequest.getDefaultInstance()))
.setResponseMarshaller(getObjectMediaResponseMarshaller)
.build();
GrpcCallSettings<ReadObjectRequest, ReadObjectResponse> readObjectTransportSettings =
GrpcCallSettings.<ReadObjectRequest, ReadObjectResponse>newBuilder()
.setMethodDescriptor(readObjectMethodDescriptor)
.setParamsExtractor(
request -> {
RequestParamsBuilder builder = RequestParamsBuilder.create();
builder.add(request.getBucket(), "bucket", PathTemplate.create("{bucket=**}"));
return builder.build();
})
.build();Describe the solution you'd like
Having a way to configure response unmarshaler for a given RPC in an existing GAPIC client would remove having to maintain this additional code. We currently only need it for ReadObject requests but there will be another RPC soon that will most likely also require this unmarshaler as well.
Describe alternatives you've considered
For now we are implementing it this way to unblock zero copy unmarshaler implementation.
Additional context
- There's an internal doc on this design that I can share with your team offline.
- Prototype: [Prototype] Test zero copy for reads java-storage#2420