KEMBAR78
fix: support devices with cutouts for DataDrivenDatasetStylingActivity.java demo by dkhawk · Pull Request #1979 · googlemaps-samples/android-samples · GitHub
Skip to content

Conversation

@dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Feb 14, 2025

No description provided.

@dkhawk dkhawk requested a review from kikoso February 14, 2025 00:22
@kikoso kikoso changed the title fix: support devices with cutouts for DataDrivenDatasetStylingActivit… fix: support devices with cutouts for DataDrivenDatasetStylingActivity.java demo Feb 14, 2025
@kikoso
Copy link
Collaborator

kikoso commented Feb 14, 2025

Looks good! Some minor comments on the README file.

Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…selection

This commit enhances the DataDrivenBoundariesActivity demo with UI and
functionality improvements focusing on boundary type selection and visual
enhancements.

- Implements Material Design theming and UI elements.
- Adds boundary type selection via PopupMenu (Locality, Admin Area, Country).
- Refactors styling and implements persistent country selection.
- Handles system UI insets for improved display.

These changes improve the demo's user experience and code structure,
better showcasing data-driven boundary styling.
This commit introduces dataset-specific zoom levels to the DataDrivenDatasetStylingActivity, enhancing the user experience when switching between datasets.

- Adds a `zoomLevel` field to the `DataSet` class to store the desired zoom level for each dataset.
- Updates the `dataSets` array to include appropriate zoom levels for Boulder, New York, and Kyoto datasets.
- Modifies the `centerMapOnLocation` method to accept a `zoomLevel` parameter, allowing it to be dynamically set.
- Updates the `switchDataSet` method to utilize the `zoomLevel` from the selected `DataSet` when centering the map, ensuring the map zooms to the optimal level for each dataset.
- Removes the previously hardcoded `ZOOM_LEVEL` constant, as the zoom level is now dataset-dependent.

These changes ensure that when a user selects a dataset, the map automatically zooms to a relevant level for that specific dataset, improving clarity and usability of the demo.

Also adds missing copyright header.
@dkhawk dkhawk merged commit 683b21d into main Feb 14, 2025
10 checks passed
@dkhawk dkhawk deleted the fix/datadrivenstyling-cutout-support branch February 14, 2025 22:51
googlemaps-bot pushed a commit that referenced this pull request Feb 14, 2025
## [1.15.1](v1.15.0...v1.15.1) (2025-02-14)

### Bug Fixes

* support devices with cutouts for DataDrivenDatasetStylingActivity.java demo ([#1979](#1979)) ([683b21d](683b21d))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants