Add regression test capturing need for withCause call
#460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
commented
Nov 17, 2023
| // the exception should not propagate to the client | ||
| assertThat(clientException.cause).isNull() | ||
|
|
||
| assertThat(clientException.status.code).isEqualTo(Status.Code.INTERNAL) |
There was a problem hiding this comment.
The status code is captured from the Exception's causal StatusException.
jamesward
approved these changes
Nov 17, 2023
|
Good catch! Thanks for adding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed when writing #456 is that with the new branch capturing Status exceptions, the existing regression test that I modified to throw a non-status exception is no longer sufficient to ensure the stack trace is available to the interceptor. Concretely,
Status.fromThrowable(exception)will always haveexceptionas the cause of the status so long asexceptionis not a Status exception and has no Status exception in its causal chain.This PR adds a test covering that case; without the extra
withCausecall this test will fail.