KEMBAR78
Fix lint in HackfmtFormatter.hack by alexeyt · Pull Request #145 · hhvm/hack-codegen · GitHub
Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Conversation

@alexeyt
Copy link
Contributor

@alexeyt alexeyt commented Apr 11, 2022

Our CI was failing with:

  + hhvm vendor/hhvm/hhast/bin/hhast-lint
  You have made a lambda which forwards all its arguments to a static method or function.
  The order of the parameters is the same as the order of the arguments.
  You could create a function reference instead. -> \escapeshellarg<>
    Linter: DontCreateForwardingLambdas
    Location: /home/runner/work/hack-codegen/hack-codegen/src/HackfmtFormatter.hack:74:6
    Code:
    >      $option ==> \escapeshellarg($option)

on HHVM latest. Apply the change suggested by the linter.

@alexeyt alexeyt merged commit 7339735 into hhvm:main Apr 12, 2022
@alexeyt alexeyt deleted the alexeyt-fix-lint branch April 14, 2022 12:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants