KEMBAR78
Comparing v4.166.0...v4.166.1 · hhvm/hhast · GitHub
Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hhvm/hhast
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.166.0
Choose a base ref
...
head repository: hhvm/hhast
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.166.1
Choose a head ref
  • 6 commits
  • 49 files changed
  • 4 contributors

Commits on Aug 10, 2022

  1. Update schema (#502)

    Co-authored-by: Hack OSS Team <hhvm-oss@fb.com>
    github-actions[bot] and Hack OSS Team authored Aug 10, 2022
    Configuration menu
    Copy the full SHA
    4cc67d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    20855bd View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Update schema (#504)

    Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
    github-actions[bot] and HHVM/Hack Open Source authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e0a5e28 View commit details
    Browse the repository at this point in the history
  2. Fix some shortcomings of UnusedParameterLinter (#506)

    - Variadic parameters were not checked
       function _(int ... $x): void {} now emits an error for $x.
    - Lambda parameters are now linted in unparenthesized params.
       $x ==> 0 now emits an error for $x.
       Same applies for (int ... $x) ==> 0.
     - Added explicit tests for old style variadics.
       The linter handled them fine, but there was no test for it.
    Checking for unparenthesized lambda parameters required a new linter.
    The UnusedParameterLinter checked against ParameterDeclaration.
    $x ==> 0; does not introduce one, so a new TNode was required.
    This PR may cause old HHAST_FIXME comments to break.
    You will have to upgrade:
    /*HHAST_FIXME[UnusedParameter]*/ ($x) ==> 0; to
    /*HHAST_FIXME[UnusedLambdaParameter]*/ ($x) ==> 0;
    I suspect this linter is rarely suppressed, since the autofix is easier.
    lexidor authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0b8dee8 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Update schema (#507)

    Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
    github-actions[bot] and HHVM/Hack Open Source authored Aug 19, 2022
    Configuration menu
    Copy the full SHA
    104c71b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Update schema (#509)

    Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
    github-actions[bot] and HHVM/Hack Open Source authored Aug 25, 2022
    Configuration menu
    Copy the full SHA
    ca79177 View commit details
    Browse the repository at this point in the history
Loading