This repository was archived by the owner on Dec 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: hhvm/hhast
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.166.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: hhvm/hhast
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.166.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 51 files changed
- 4 contributors
Commits on Sep 21, 2022
-
Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
Configuration menu - View commit details
-
Copy full SHA for 0b43009 - Browse repository at this point
Copy the full SHA 0b43009View commit details -
Configure "yes to all" per linter (#516)
* Configure "yes to all" per linter fixes #86 In order to make this change backwards compatible, allowYesToAll() defaults to true. Unsafe linters may override this to false. I also considered a default of false, but that would entail altering all safe linters (including third-party). Unsafe linters may need to suppress `must use override` linter if they wish to remain compatible with previous versions of hhast. * Add allowYesToAll() to unsafe linters Some linters look like they might be unsafe, but aren't on close inspection. I added allowYesToAll(): bool { return true; } on those. I checked every autofixing linter. If I could not find a bad autofix, I left the linter untouched. * Revert allowYesToAll to true I changed this during testing and forgot to flip it back. * Correct mistaken variable name in comment The example first used `$a` as a meta syntactic variable. I later changed to `$k` and `$v` for key and value. I didn't update every use of `$_a`. * Move allowYesToAll() down the type hierarchy Suggested in a code review. This only makes sense for autofixing linters. * Rename allowYesToAll() to areBulkAutoFixesSafe()
Configuration menu - View commit details
-
Copy full SHA for 8ed03af - Browse repository at this point
Copy the full SHA 8ed03afView commit details
Commits on Sep 26, 2022
-
Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
Configuration menu - View commit details
-
Copy full SHA for 167dcb6 - Browse repository at this point
Copy the full SHA 167dcb6View commit details
Commits on Sep 27, 2022
-
Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
Configuration menu - View commit details
-
Copy full SHA for dee5b58 - Browse repository at this point
Copy the full SHA dee5b58View commit details
Commits on Oct 3, 2022
-
Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
Configuration menu - View commit details
-
Copy full SHA for 28ff1f4 - Browse repository at this point
Copy the full SHA 28ff1f4View commit details
Commits on Oct 6, 2022
-
Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
Configuration menu - View commit details
-
Copy full SHA for 3f5c3b2 - Browse repository at this point
Copy the full SHA 3f5c3b2View commit details
Commits on Oct 14, 2022
-
Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
Configuration menu - View commit details
-
Copy full SHA for 5793559 - Browse repository at this point
Copy the full SHA 5793559View commit details
Commits on Nov 1, 2022
-
Document the hhast-lint.json file in detail (#520)
* Document the hhast-lint.json file in detail linters-usage.md does not document these options and suggests reading the sources instead. Although the type is somewhat well commented, I felt like a bit of conventional documentation would go a long way. * Update linters-usage to refer to configuring-hhast-lint * Make hhast a dev dependency by default * Oops, you dropped something... * Typo fixes * Fix href of link and more bad spelling * Remove lintMarkerAllowList documentation This feature will be implemented as a linter instead. * Document case sensitivity Refers to: #517 (comment) * Document the lowerCamelCase in a comment See: #517 (comment) * Remove section that referred to lintMarkerAllowList
Configuration menu - View commit details
-
Copy full SHA for 14c9fc7 - Browse repository at this point
Copy the full SHA 14c9fc7View commit details
Commits on Nov 3, 2022
-
Let TypeRefinement implement ITypeSpecifier (#533)
This PR let `TypeRefinement` implement `ITypeSpecifier` and the update schame version to `2022-09-29-0000`, fixing the CI on `main` branch. Without this PR, many places that were `ITypeSpecifier` now become `Node`, resulting compilation errors.
Configuration menu - View commit details
-
Copy full SHA for 0fdd1f0 - Browse repository at this point
Copy the full SHA 0fdd1f0View commit details -
Co-authored-by: HHVM/Hack Open Source <hhvm-oss@fb.com>
Configuration menu - View commit details
-
Copy full SHA for 02d91f2 - Browse repository at this point
Copy the full SHA 02d91f2View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.166.2...v4.166.3