KEMBAR78
Use `vec` instead of `keyset` in `HHClientLinter::TConfig` by Atry · Pull Request #397 · hhvm/hhast · GitHub
Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Nov 23, 2021

Copy link
Contributor

@fredemmott fredemmott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep; we require that the deserialized json matches the provided shape, and keysets aren't representable directly in json.

@Atry Atry merged commit 449ff79 into hhvm:main Nov 23, 2021
@Atry Atry deleted the vec-config branch November 23, 2021 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants