This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Don't ignore 5607 lint error under src/Migrations and fix an existing 5607 lint error #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atry
force-pushed
the
fix-5607-lint-error
branch
from
aa9b408 to
2e90ff6
Compare
Atry
changed the title
|
can you unstack this (and leave out the configuration change for now), so that it can be tested/merged/reverted independently? |
Atry
force-pushed
the
fix-5607-lint-error
branch
from
2e90ff6 to
df9be4e
Compare
|
Rebased |
Atry
force-pushed
the
fix-5607-lint-error
branch
from
df9be4e to
01a62b3
Compare
fredemmott
reviewed
Dec 2, 2021
Atry
force-pushed
the
fix-5607-lint-error
branch
from
01a62b3 to
6851061
Compare
fredemmott
reviewed
Dec 7, 2021
| "patterns": ["src/Migrations/*"], | ||
| "linterConfigs": { | ||
| "Facebook\\HHAST\\HHClientLinter": { | ||
| "ignore": [5624, 5639] |
There was a problem hiding this comment.
bump - this is what I'm referring to
There was a problem hiding this comment.
Currently the global ignore code list is [5607, 5624, 5639], so this commit actually enabled 5607 error code in comparison to the global ignore list
fredemmott
approved these changes
Dec 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a 5607 linter error under
src/Migrations. I reviewed$t->getLeading() !== $t->getLeadingWhitespace()and I believe the condition is alwaystrue, therefore, I removed theifclause.