KEMBAR78
Don't create the PR to update the latest breaking version if the latest breaking version is not changed by Atry · Pull Request #465 · hhvm/hhast · GitHub
Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Jun 1, 2022

#462 added a github action job to create pull requests. One of the pull request created by the job is to update the latest breaking version. However the pull request is unnecessary if the latest breaking version is the current version. This PR will prevent the pull request from being created when it is unnecessary.

Note that the other PR to update schema will still be created. For example, #463 and #464 are identical, so #464 is unnecessary while #463 is good.

@Atry Atry requested review from Wilfred, alexeyt and lexidor June 1, 2022 22:07
@Atry Atry changed the title Don't create the PR to update the latest breaking version if latest breaking version is not changed Don't create the PR to update the latest breaking version if the latest breaking version is not changed Jun 1, 2022
@Atry Atry merged commit afc2de2 into hhvm:main Jun 2, 2022
@Atry Atry deleted the Atry-patch-3 branch June 2, 2022 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants