KEMBAR78
Remove `aiohttp` from direct dependencies by akx · Pull Request #7294 · huggingface/datasets · GitHub
Skip to content

Conversation

@akx
Copy link
Contributor

@akx akx commented Nov 18, 2024

The dependency is only used for catching an exception from other code. That can be done with an import guard.

akx and others added 2 commits November 18, 2024 15:58
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great ! I moved it to optional dependencies

@lhoestq lhoestq merged commit a6461e9 into huggingface:main May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants