KEMBAR78
Add with_split to DatasetDict.map by jp1924 · Pull Request #7368 · huggingface/datasets · GitHub
Skip to content

Conversation

@jp1924
Copy link
Contributor

@jp1924 jp1924 commented Jan 13, 2025

@jp1924
Copy link
Contributor Author

jp1924 commented Jan 13, 2025

Can you check this out, @lhoestq?

@jp1924
Copy link
Contributor Author

jp1924 commented Jan 20, 2025

cc @lhoestq @albertvillanova

@jp1924
Copy link
Contributor Author

jp1924 commented Feb 4, 2025

@lhoestq

@jp1924
Copy link
Contributor Author

jp1924 commented Feb 12, 2025

@lhoestq

1 similar comment
@jp1924
Copy link
Contributor Author

jp1924 commented Feb 13, 2025

@lhoestq

@jp1924 jp1924 requested a review from lhoestq February 21, 2025 07:50
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! just added minor comments but LGTM

before we merge can you also ad the same for IterableDatasetDict ?

@jp1924 jp1924 requested a review from lhoestq February 24, 2025 12:48
@jp1924
Copy link
Contributor Author

jp1924 commented Mar 3, 2025

@lhoestq

@jp1924
Copy link
Contributor Author

jp1924 commented Mar 6, 2025

@lhoestq please...

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! and sorry for the delay !

@lhoestq lhoestq merged commit f693f4e into huggingface:main Mar 7, 2025
14 checks passed
@jp1924
Copy link
Contributor Author

jp1924 commented Mar 8, 2025

Thank you so much for reviewing this PR! Have a great weekend~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants