KEMBAR78
Support skip_trying_type by yoshitomo-matsubara · Pull Request #7483 · huggingface/datasets · GitHub
Skip to content

Conversation

@yoshitomo-matsubara
Copy link
Contributor

@yoshitomo-matsubara yoshitomo-matsubara commented Mar 27, 2025

This PR addresses Issue #7472

cc: @lhoestq

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lhoestq
Copy link
Member

lhoestq commented Apr 7, 2025

Cool ! Can you run make style to fix code formatting ?

I was also thinking of naming the argument try_original_type and have it True by default

@yoshitomo-matsubara
Copy link
Contributor Author

@lhoestq

Thank you for the suggestion! I renamed the argument with True by default and ran make style
Does it look good?

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great !

@yoshitomo-matsubara
Copy link
Contributor Author

Thanks @lhoestq !

Let me know if there are anything that I can do for this PR. Otherwise, looking forward to seeing this update in the package soon!

@lhoestq
Copy link
Member

lhoestq commented Apr 9, 2025

CI failures are unrelated, merging :)

@lhoestq lhoestq merged commit 90e5bf8 into huggingface:main Apr 9, 2025
8 of 14 checks passed
@yoshitomo-matsubara
Copy link
Contributor Author

Great, thanks for your support!
I can't wait for the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants