Fix enable memory efficient attention on ROCm #10564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while calling CK implementation
refactor of picking a set element
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
approved these changes
Jan 31, 2025
|
Failing Flax Test is unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix enable memory efficient attention on ROCm while calling CK implementation
https://github.com/facebookresearch/xformers/blob/main/xformers/ops/fmha/ck.py#L157
Bug cause: the only supported dtypes by the op are float16 and bfloat16, and by default the input tensor is initialized as float32, which prevents using memory efficient attention on ROCm
Bug fix: pick a supported dtype when a custom attention op is passed as an argument
Note: attention op is not a Callable but a pair of (forward, backward) op implementations
https://github.com/facebookresearch/xformers/blob/main/xformers/ops/fmha/__init__.py#L202
https://github.com/facebookresearch/xformers/blob/main/xformers/ops/fmha/common.py#L469
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.