KEMBAR78
[fix] refer use_framewise_encoding on AutoencoderKLHunyuanVideo._encode by hanchchch · Pull Request #10600 · huggingface/diffusers · GitHub
Skip to content

[fix] refer use_framewise_encoding on AutoencoderKLHunyuanVideo._encode #10600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2025
Merged

[fix] refer use_framewise_encoding on AutoencoderKLHunyuanVideo._encode #10600

merged 3 commits into from
Jan 28, 2025

Conversation

@hanchchch
Copy link
Contributor

What does this PR do?

AutoencoderKLHunyuanVideo._encode is currently refering to use_framewise_decoding, instead of use_framewise_encoding. Fixed it to use_framewise_encoding

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

a-r-r-o-w
a-r-r-o-w approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@hanchchch
Copy link
Contributor Author

have no idea why the test is failing lol

@hanchchch hanchchch requested a review from a-r-r-o-w January 28, 2025 01:03
@a-r-r-o-w
Copy link
Contributor

Hey! Sorry for the delay, I forgot about merging :/ The failing test looks unrelated. Just to be sure, will trigger it again and merge

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@a-r-r-o-w a-r-r-o-w merged commit f295e2e into huggingface:main Jan 28, 2025
12 checks passed
@hanchchch hanchchch deleted the patch-1 branch January 30, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanchchch @a-r-r-o-w @HuggingFaceDocBuilderDev