KEMBAR78
[Tests] conditionally check `fp8_e4m3_bf16_max_memory < fp8_e4m3_fp32_max_memory` by sayakpaul · Pull Request #10669 · huggingface/diffusers · GitHub
Skip to content

[Tests] conditionally check fp8_e4m3_bf16_max_memory < fp8_e4m3_fp32_max_memory #10669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 28, 2025
Merged

[Tests] conditionally check fp8_e4m3_bf16_max_memory < fp8_e4m3_fp32_max_memory #10669

merged 7 commits into from
Jan 28, 2025

Conversation

@sayakpaul
Copy link
Member

Have checked on the following devices: T4, A100, RTX 4090.

@sayakpaul sayakpaul requested review from DN6 and a-r-r-o-w January 28, 2025 05:43
a-r-r-o-w
a-r-r-o-w approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! LGTM

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul merged commit 7b100ce into main Jan 28, 2025
15 checks passed
@sayakpaul sayakpaul deleted the conditional-checking-layerwise-upcast branch January 28, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6 DN6 Awaiting requested review from DN6

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sayakpaul @HuggingFaceDocBuilderDev @a-r-r-o-w