KEMBAR78
[chore] deprecate blip controlnet pipeline. by sayakpaul · Pull Request #11877 · huggingface/diffusers · GitHub
Skip to content

Conversation

sayakpaul
Copy link
Member

What does this PR do?

transformers has likely introduced a breaking change which is what is causing this:

FAILED tests/pipelines/controlnet/test_controlnet_blip_diffusion.py::BlipDiffusionControlNetPipelineFastTests::test_attention_slicing_forward_pass - TypeError: CLIPEncoder.forward() got an unexpected keyword argument 'return_dict'

But in retrospect, we should deprecate the BLIP ControlNet pipeline anyway. This PR does that.

@sayakpaul sayakpaul requested a review from DN6 July 7, 2025 07:33
@DN6
Copy link
Collaborator

DN6 commented Jul 7, 2025

Just need to add last_supported_version to the class

_last_supported_version = "0.33.1"

@sayakpaul
Copy link
Member Author

Thanks. In general, do you think we should get rid of the tests for the deprecated pipelines? Will reduce LoC. @DN6

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6
Copy link
Collaborator

DN6 commented Jul 7, 2025

We can remove the pipeline tests, yes

@sayakpaul sayakpaul merged commit 2c30287 into main Jul 7, 2025
15 checks passed
@sayakpaul sayakpaul deleted the deprecate-blip-controlnet branch July 7, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants