KEMBAR78
Added Annotations for PyTorch models by anmolsjoshi · Pull Request #16619 · huggingface/transformers · GitHub
Skip to content

Added Annotations for PyTorch models #16619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 6, 2022
Merged

Added Annotations for PyTorch models #16619

merged 16 commits into from
Apr 6, 2022

Conversation

@anmolsjoshi
Copy link
Contributor

@anmolsjoshi anmolsjoshi commented Apr 5, 2022 •
edited
Loading

What does this PR do?

Adds annotations as described in #16059:

  • Updated type annotations for CTRL (PT), RAG(PT)
  • added type annotations for FSMT(PT), LED(PT), M2M(PT), MPNet(PT) , Nystromformer(PT), OpenAI(PT)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 6, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@anmolsjoshi anmolsjoshi changed the title Added Annotations for MPNet, Updated Annotations for CTRL Added Annotations for PyTorch models Apr 6, 2022
@anmolsjoshi
Copy link
Contributor Author

@sgugger not sure why the tests are failing. I'm pretty sure they aren't related to added annotations

sgugger
sgugger approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all of those!

@sgugger
Copy link
Collaborator

sgugger commented Apr 6, 2022

Thanks! We just need a last make style on your branch for the code quality check :-)

@sgugger sgugger merged commit 8ac9b82 into huggingface:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anmolsjoshi @HuggingFaceDocBuilderDev @sgugger