KEMBAR78
Fix QA sample by ydshieh · Pull Request #16648 · huggingface/transformers · GitHub
Skip to content

Fix QA sample #16648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2022
Merged

Fix QA sample #16648

merged 3 commits into from
Apr 8, 2022

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Apr 7, 2022 •
edited
Loading

What does this PR do?

Try to address the issue about PT_QUESTION_ANSWERING_SAMPLE discussed in the following 2 comments:

#16523 (comment)

#16523 (comment)

@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 7, 2022 •
edited
Loading

@patrickvonplaten @sgugger

I would like to have a feedback to see if this is in good direction.

@sgugger make style will break the line into 2 lines. But when replacing the qa_target_start_index and qa_target_end_index by 14 & 15, it actually fits in one line. Should I use a shorter name like qa_target_start_idx or qa_start_index for example?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 7, 2022

cc @vumichien and @bhadreshpsavani to keep them updated

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 7, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh mentioned this pull request Apr 7, 2022
Closed
5 tasks
sgugger
sgugger reviewed Apr 7, 2022
View reviewed changes
src/transformers/utils/doc.py Outdated
Comment on lines 210 to 212
>>> target_start_index, target_end_index = torch.tensor([{qa_target_start_index}]), torch.tensor(
... [{qa_target_end_index}]
... )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be on two separate lines since there is formatting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ydshieh ydshieh marked this pull request as ready for review April 7, 2022 14:47
@ydshieh ydshieh changed the title [WIP] Fix QA sample Fix QA sample Apr 7, 2022
@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 7, 2022

I should do the same for TF_QUESTION_ANSWERING_SAMPLE. Currently just to have some feedbacks from you if any :-)

@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 8, 2022

I also changed TF_QUESTION_ANSWERING_SAMPLE.

Ran locally for Roberta and TFRoberta, and their doctest pass.

Ready for @sgugger to give a final look :-)

sgugger
sgugger approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ydshieh ydshieh merged commit ab22966 into huggingface:main Apr 8, 2022
@ydshieh
Copy link
Collaborator Author

ydshieh commented Apr 8, 2022

@vumichien @bhadreshpsavani

Could you pull the latest change into the master/main branch of your local clone, rebase your working branch for this sprint, and check if the QA doc example can now pass the doctest, please? Thanks a lot!

@ydshieh ydshieh deleted the fix_qa_doc_sample branch April 8, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ydshieh @HuggingFaceDocBuilderDev @sgugger