deci gguf support #38669
Merged
deci gguf support #38669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MekkCyber
approved these changes
Jun 11, 2025
Isotr0py
reviewed
Jun 12, 2025
tests/quantization/ggml/test_ggml.py
Outdated
Comment on lines
983
to
992
| try: | ||
| original_model = AutoModelForCausalLM.from_pretrained( | ||
| original_model_id, | ||
| torch_dtype=torch.float16, | ||
| trust_remote_code=True, | ||
| device_map="auto", | ||
| ) | ||
| except Exception as e: | ||
| self.skipTest(f"Original Deci model not available for comparison: {e}") | ||
| return |
There was a problem hiding this comment.
Why do we need this try: ... excetpt: .... statement in test? Should't the test failed if it encounter an Exception?
There was a problem hiding this comment.
Can you address this too?
|
hey , any update on this ? |
I think after resolving conflicts we're good to go? Looking forward to this pr! Thanks. |
Isotr0py
approved these changes
Jul 29, 2025
tests/quantization/ggml/test_ggml.py
Outdated
Comment on lines
983
to
992
| try: | ||
| original_model = AutoModelForCausalLM.from_pretrained( | ||
| original_model_id, | ||
| torch_dtype=torch.float16, | ||
| trust_remote_code=True, | ||
| device_map="auto", | ||
| ) | ||
| except Exception as e: | ||
| self.skipTest(f"Original Deci model not available for comparison: {e}") | ||
| return |
There was a problem hiding this comment.
Can you address this too?
|
thanks for keeping up with the pr ❤️ |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: ggml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GGUF support for deci
Fixes #37736
Before submitting
Who can review?
@MekkCyber