Fix default values of getenv #39867
Merged
Fix default values of getenv #39867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyy <cyyever@outlook.com>
|
[For maintainers] Suggested jobs to run (before merge) run-slow: modernbert, whisper |
|
Not sure about this one! I understand that envvars are all strings, but I think it's fine to set a non-string default when they're missing, right? Is there a PEP or Ruff rule about this? |
Rocketknight1
approved these changes
Aug 7, 2025
Comment on lines
+216
to
+217
| "sm_number_gpu": os.getenv("SM_NUM_GPUS", "0"), | ||
| "sm_number_cpu": os.getenv("SM_NUM_CPUS", "0"), |
There was a problem hiding this comment.
This case actually does fix an inconsistency - the return value is an int when the envvar isn't set and a string otherwise. In most other cases the default value is inside an int() call anyway
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The default value of getenv should be a string or None.