Fix gemma3n feature extractor's incorrect squeeze #39919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isotr0py <2037008807@qq.com>
Isotr0py
changed the title
Isotr0py
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Yep that mask error looks gone now, thanks for the fix @Isotr0py ! |
|
cc @eustlb @zucchini-nlp - this makes sense to me if you're happy with it! |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma3n |
|
run-slow: gemma3n |
zucchini-nlp
approved these changes
Aug 7, 2025
|
This comment contains run-slow, running the specified jobs: models: ['models/gemma3n'] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #39911
mel_spectrogramin gemma3n processorTODO:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
cc @NickLucche Can you check if this fix works on your gemma3n PR? Thanks!