Harmonize past_key_value to past_key_valueS everywhere
#39956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
changed the title
past_key_value to past_key_values everywherepast_key_value to past_key_valueS everywhere
ArthurZucker
reviewed
Aug 8, 2025
ArthurZucker
approved these changes
Aug 8, 2025
ArthurZucker
reviewed
Aug 8, 2025
Comment on lines
73
to
77
| if "past_key_value" in kwargs and kwargs["past_key_value"] is not None: | ||
| kwargs["past_key_value"] = None | ||
| message += " `past_key_value=None`," | ||
| do_warn = True | ||
|
|
There was a problem hiding this comment.
to not break we still nedd this no?
There was a problem hiding this comment.
Humm good catch, since the decorator will change the name correctly on the forward args but this is __call__ of the Module, I believe it should indeed still be there!
|
[For maintainers] Suggested jobs to run (before merge) run-slow: arcee, aria, autoformer, bamba, bart, bert, bert_generation, big_bird, bigbird_pegasus, biogpt, bitnet, blenderbot, blenderbot_small |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title. I'm getting annoyed to see both, it was time to finally make it coherent everywhere.
All the changes are made, so I'll only need to remove the decorators after next release (it's only internal modules, so no need for a long deprecation cycle)
Also reapplied modular to
examples/modular-transformer