Add Keypoint Matcher pipeline #39970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevhliu
reviewed
Aug 6, 2025
|
@stevhliu I've added docs to SuperGlue, LightGlue and EfficientLoFTR (SuperPoint is a keypoint detector, not matcher, so it does not fall in the scope) |
qubvel
reviewed
Aug 7, 2025
|
[For maintainers] Suggested jobs to run (before merge) run-slow: superglue |
sbucaille
force-pushed
the
keypoint-matcher-pipeline
branch
from
d7b18a0 to
ae27538
Compare
|
@qubvel didn't mean to do this review thing 😅 anyway can you enlightned me on this question ? |
|
@qubvel addressed the |
qubvel
approved these changes
Aug 20, 2025
|
cc @Rocketknight1 for review |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: Pavel Iakubovskii <qubvel@gmail.com>
sbucaille
force-pushed
the
keypoint-matcher-pipeline
branch
from
d8f7eff to
130b337
Compare
Rocketknight1
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements
keypoint-matcherpipeline.Quite basic for now, let me know if I should add things.
I added tests to have single and multiple pairs as well as checking it correctly fails when there is only one image provided.
Committed on top of #39968 but will be rebased on main once the fix is merged
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@qubvel @stevhliu