KEMBAR78
Various test fixes for AMD by remi-or · Pull Request #39978 · huggingface/transformers · GitHub
Skip to content

Conversation

@remi-or
Copy link
Collaborator

@remi-or remi-or commented Aug 7, 2025

This PR introduces minor test fixes for 4 different models:

  • for internvl we add an Expectation for ROCm 9.4 and remove a tensor being created from a tensor;
  • for llama we add an Expectation for ROCm 9.4;
  • for llava we add the @require_bitsandbytes decorator for a test requires bitsandbytes;
  • for mistral3 we add an Expectation for ROCm 9.4;

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: internvl, llama, llava, mistral3

Copy link
Member

@ivarflakstad ivarflakstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@remi-or remi-or merged commit 597ed1a into huggingface:main Aug 7, 2025
18 checks passed
@ydshieh
Copy link
Collaborator

ydshieh commented Aug 7, 2025

Thank you both for the work and the autonomy of handling AMD PRs.

I am cooking something to ease the process of updating expected values, will share soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants