fix: remove CHAT_TEMPLATE import in tests for deepseek-vl #40003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geetu040
changed the title
|
@zucchini-nlp, this is ready for review. I've checked there is no other leaking import. |
zucchini-nlp
reviewed
Aug 7, 2025
| image_processor=image_processor, | ||
| tokenizer=tokenizer, | ||
| chat_template=CHAT_TEMPLATE, | ||
| chat_template="dummy_template", |
There was a problem hiding this comment.
can we propagate the kwargs from cls.prepare_processor_dict() here, so it saves the cprrect chat template in tmpDir?
There was a problem hiding this comment.
@zucchini-nlp
yes we can, updated in 8443e89
|
[For maintainers] Suggested jobs to run (before merge) run-slow: deepseek_vl, deepseek_vl_hybrid |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #39966
This PR removes the
CHAT_TEMPLATEimports fromtest_processing_deepseek_vl.pyandtest_processing_deepseek_vl_hybrid.py. These imports were referencing weight conversion scripts that are not included in the PyPI distribution, which causes the tests to fail in the v4.55.0 release.The fix aligns with the approach used in test_processing_emu3.py
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
@rasmi @zucchini-nlp @ArthurZucker